Bug 11867

Summary:	make 3.82 target-specific variables fail if over 150 characters and contain semicolon
Product:	Mageia	Reporter:	Kevin Bulgrien <kbulgrien>
Component:	RPM Packages	Assignee:	Thomas Backlund <tmb>
Status:	RESOLVED OLD	QA Contact:
Severity:	normal
Priority:	Normal	CC:	tmb
Version:	3
Target Milestone:	---
Hardware:	All
OS:	Linux
URL:	http://savannah.gnu.org/bugs/?36106
Whiteboard:
Source RPM:	make-3.82-6.mga3.src.rpm	CVE:
Status comment:
Attachments:	Patch to make 3.82 to fix this bug. Test file to detect the problem and to test the fix.

Description Kevin Bulgrien 2013-12-04 02:08:19 CET

Description of problem:

I have a standard Makefile that as successfully been used for years that suddenly breaks on Mageia 3.

The bug is triggered by a long target-specific variable assignment that
contains one or more semicolon characters.

Apparently if affects target-specific variables and if the value assigned contains semicolons and is over 150 characters, the assignment throws an error like:

/home/admin/share/pkg/local/Makefile.inc:91: *** Malformed target-specific variable definition.  Stop.

Version-Release number of selected component (if applicable):

Name        : make
Epoch       : 1
Version     : 3.82
Release     : 6.mga3

How reproducible:

See the following URL for a Makefile that triggers the bug.

http://savannah.gnu.org/bugs/download.php?file_id=25595

Steps to Reproduce:

bash $ gmake -f test.makefile a
test.makefile:1: *** Malformed target-specific variable definition. Stop.

bash-4.1$ gmake --version
GNU Make 3.82

Remove one 'e' or a semicolon from the above and it suddenly works.
Patch to fix this issue attached.

The version of make needs to be bumped.

The upstream bug report posts a patch.

Upstream reports the bug is fixed in make version 4.0.



Reproducible: 

Steps to Reproduce:

Comment 1 Kevin Bulgrien 2013-12-04 02:16:10 CET

Cauldron has a fixed version that needs to be pulled into 3:

make-4.0-2.mga4

Comment 2 Kevin Bulgrien 2013-12-04 03:38:30 CET

I used rpmbuild to build the Cauldron source RPM and installed this version of make on Mageia 3.  The bug disappeared.

Comment 3 Thomas Backlund 2013-12-04 07:51:35 CET

(In reply to Kevin Bulgrien from comment #1)
> Cauldron has a fixed version that needs to be pulled into 3:
> 
> make-4.0-2.mga4

Nope.

Make 4.0 introduces some fixes needing to be done all over the mga3 packages, something we wont be doing on a stable release.

If we want to fix this in a stable release, we need to find the exact fix in upstream tree and backport that one.

CC: (none) => tmb
Assignee: bugsquad => tmb

Comment 4 Kevin Bulgrien 2014-04-17 07:08:21 CEST

This is the bug:

http://savannah.gnu.org/bugs/?36106

This is the patch:

http://savannah.gnu.org/bugs/download.php?file_id=25596

Comment 5 Kevin Bulgrien 2014-04-17 07:10:09 CEST

Created attachment 5121 [details]
Patch to make 3.82 to fix this bug.

This is the patch posted with the upstream bug report.

Comment 6 Kevin Bulgrien 2014-04-17 07:13:14 CEST

Created attachment 5122 [details]
Test file to detect the problem and to test the fix.

This file can be used to reproduce the bug and to determine whether the patch fixes it or not.  It was obtained from the upstream bug report.

Comment 7 Marja Van Waes 2015-03-31 16:04:19 CEST

Mageia 3 changed to end-of-life (EOL) status 4 months ago.
http://blog.mageia.org/en/2014/11/26/lets-say-goodbye-to-mageia-3/ 

Mageia 3 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of Mageia
please feel free to click on "Version" change it against that version of Mageia
and reopen this bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

--
The Mageia Bugsquad

Status: NEW => RESOLVED
Resolution: (none) => OLD