Bug 11824

Summary: 4pre-beta2 help text missing for sound configuration screen in stage 2
Product: Mageia Reporter: Marja Van Waes <marja11>
Component: InstallerAssignee: Thierry Vignaud <thierry.vignaud>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal CC: doc-bugs, marja11, thierry.vignaud
Version: Cauldron   
Target Milestone: ---   
Hardware: i586   
OS: Linux   
Whiteboard: 5beta1
Source RPM: CVE:
Status comment:

Description Marja Van Waes 2013-11-29 22:25:33 CET
While ugrading with the Mageia 4 beta2 - DVD 32 bits of Nov 26, when clickin on "help" in the sound configuration screen, only a file tree becomes visible. 

In the past, a help text was visible that was not written by docteam.

It was probably taken from this part of drakx/perl-install/harddrake/sound.pm
(lines 370-380)
******************************************************************************
interactive_help => sub {
                                      N("OSS (Open Sound System) was the first sound API. It's an OS independent sound API (it's available on most UNIX(tm) systems) but it's a very basic and limited API.
What's more, OSS drivers all reinvent the wheel.

ALSA (Advanced Linux Sound Architecture) is a modularized architecture which
supports quite a large range of ISA, USB and PCI cards.\n
It also provides a much higher API than OSS.\n
To use alsa, one can either use:
- the old compatibility OSS API
- the new ALSA API that provides many enhanced features but requires using the ALSA library.
");
                                       },
******************************************************************************

and if that isn't where it came from, it looked just as old ;-)

If it should be replaced with a drakx-installer-help file, then which filename should it get?
Comment 1 Marja Van Waes 2013-11-29 22:27:04 CET
@ Mrs B

Do you agree with not putting this bug on the pad, and with not cc'ing others, it isn't that urgen, is it?

CC: (none) => eeeemail
Whiteboard: (none) => 4beta2

Comment 2 Thierry Vignaud 2013-11-30 09:33:00 CET
BTW I killed the OSS <-> ALSA switch button since OSS drivers were killed years ago.
Fell free to pick the filename you want ("sound-config"?).
My 2 cents.
Comment 3 claire robinson 2013-11-30 13:13:30 CET
It's a docteam bug really marja, do whatever you need with it :)

Mention it on the pad if you like. The pad is only really used by QA and Anne/Thomas.
Comment 4 Marja Van Waes 2013-12-01 15:06:05 CET
(In reply to Thierry Vignaud from comment #2)
> BTW I killed the OSS <-> ALSA switch button since OSS drivers were killed
> years ago.
> Fell free to pick the filename you want ("sound-config"?).
> My 2 cents.

re-assigning to docteam, to write that file :-)

(reminder: we need newest installer for screenshotting, because the screen changed)

Assignee: thierry.vignaud => doc-bugs

Comment 5 Marja Van Waes 2013-12-01 17:24:18 CET
@ Thierry

Thanks for letting us pick the file name :-)

Personally, I prefer soundConfig, because it is more like most other drakx-installer-help files.

I think we can re-use a lot of http://docteam.mageia.nl/en/MCC/content/draksound.html
 
However, during my upgrade Friday night, it was impossible to remove the ticks for pulse audio glitch free (the ticks and words in both lines were grey instead of black). 

Also, in the advanced screen I did not see the "Let me pick any driver" option.

Is it always like that in installer, or should the sound configuration in installer behave the same as in MCC (draksound)?
Comment 6 Marja Van Waes 2013-12-01 18:27:01 CET
(In reply to Marja van Waes from comment #5)
> @ Thierry

forgot to cc you :-/
> 
> Thanks for letting us pick the file name :-)
> 
> Personally, I prefer soundConfig, because it is more like most other
> drakx-installer-help files.

(and configureSound would be even more like them)

> 
> I think we can re-use a lot of
> http://docteam.mageia.nl/en/MCC/content/draksound.html
>  
> However, during my upgrade Friday night, it was impossible to remove the
> ticks for pulse audio glitch free (the ticks and words in both lines were
> grey instead of black). 
> 
> Also, in the advanced screen I did not see the "Let me pick any driver"
> option.
> 
> Is it always like that in installer, or should the sound configuration in
> installer behave the same as in MCC (draksound)?

CC: (none) => thierry.vignaud

Comment 7 Marek Laane 2013-12-01 18:30:20 CET
Maybe these peculiarities are related to recent changes by Thierry? (see last 9 commits in http://gitweb.mageia.org/software/drakx/log/perl-install/harddrake)
Comment 8 Marja Van Waes 2013-12-01 18:35:43 CET
(In reply to Marek Laane from comment #7)
> Maybe these peculiarities are related to recent changes by Thierry? (see
> last 9 commits in
> http://gitweb.mageia.org/software/drakx/log/perl-install/harddrake)

ah, yes, the "Let me pick any driver option" was removed for most cases:
"do not offer to pick a random driver when we've a default one"

But I look over what caused the grey-but-ticked "enable pulse audio" and "glitch free" lines.
Comment 9 Marja Van Waes 2013-12-06 21:29:36 CET
@ Thierry,

If I'm correct to think that the top text in that screen, for me:
 "Here you can select an alternative driver (either OSS or ALSA) for your sound card (Intel Corporation|82801I (ICH9 Family) HD Audio Controller)"

comes from line 199-200 of 
software/drakx/perl-install/harddrake/sound.pm :

N("Here you can select an alternative driver (either OSS or ALSA) for your sound card (%s).",
                                    $device->{description}) .

Could you then please remove those 2 lines?

Getting rid of those lines will make writing a little help text a lot easier ;-)

CC: eeeemail => (none)

Comment 10 Thierry Vignaud 2013-12-06 23:04:05 CET
Done
Comment 11 Marja Van Waes 2013-12-08 21:35:30 CET
(In reply to Thierry Vignaud from comment #10)
> Done

Thanks, Thierry :-)

soundConfig.html has been committed to git for English, French, German and Ukrainian.

We'll wait for a few more translations before packaging the files.
Marja Van Waes 2013-12-08 21:35:43 CET

Status: NEW => ASSIGNED

Comment 12 Marja Van Waes 2013-12-11 21:33:17 CET
soundConfig.html has been packaged now

http://svnweb.mageia.org/packages/cauldron/drakx-installer-help/current/?view=log

but since I'm a padawan, someone still needs to review what I did before a freeze push request can be made

I did not manage to ceate tag 4.0 for current software/drakx-installer-help, either the method I used to tag 3.6 only works the first time tagging is done, or I made a typo when I documented how i had done it.

It took me more than an hour back then to find out how to do it, so this time I prefer to wait till someone tells me

Assignee: doc-bugs => marja11

Comment 13 Marja Van Waes 2013-12-12 18:14:03 CET
(In reply to Marja van Waes from comment #12)
> 
> I did not manage to ceate tag 4.0 for current software/drakx-installer-help,
> ..... or I made a typo
> 
indeed

I had left out the "--" in

"git push --tags" 

Freeze push request has been made.


@ Thierry

re-asigning to you, in case the link to soundConfig.html still needs to be created.

Status: ASSIGNED => NEW
CC: (none) => marja11
Assignee: marja11 => thierry.vignaud

Comment 14 Marja Van Waes 2014-12-01 14:23:26 CET
Someone asked me whether this bug is still valid. I don't remember whether I checked when installing 5alpha or beta, but 

[marja@DenkBlok3Cauldron5a1 ~]$ grep -r soundConfig mgagit/software/drakx/                                                                        
[marja@DenkBlok3Cauldron5a1 ~]$

I can't find the link to soundConfig.html, so assume it is still valid.
Marja Van Waes 2014-12-01 14:23:51 CET

Whiteboard: 4beta2 => 5beta1

Comment 15 Mageia Robot 2016-07-04 16:01:41 CEST
commit f5fb51c9c0d92d8adee33bacb782a315c6b0c297
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Mon Jul 4 15:32:38 2016 +0200

    add help link for sound (mga#11824)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=f5fb51c9c0d92d8adee33bacb782a315c6b0c297
Comment 16 Thierry Vignaud 2016-07-04 16:08:52 CEST
Fixed in git.
Sorry for the delay

Status: NEW => RESOLVED
Resolution: (none) => FIXED