| Summary: | Import rpm Openteacher | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Dimitrios Glentadakis <dglent> |
| Component: | New RPM package request | Assignee: | Shlomi Fish <shlomif> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | cooker |
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | i586 | ||
| OS: | Linux | ||
| URL: | http://openteacher.org/en/ | ||
| Whiteboard: | |||
| Source RPM: | CVE: | ||
| Status comment: | |||
|
Description
Dimitrios Glentadakis
2013-11-10 12:33:57 CET
you don't have a mentor ? Since more than 8 months i don't have any answer from him, i suppose that he is busy(?). looks like it is oliver; he write a mail today. an in such case you could contact malo You need to fix the %description tag. List of features and architectures availability doesn't belong there. Remove everything from and including "OpenTeacher 3.0 has the following features" down to the %prep section. Also the Source0 link should be replaced with: http://downloads.sourceforge.net/%{name}/%{name}_%{version}_linux.tar.gz CC:
(none) =>
cooker Ok, done http://svnweb.mageia.org/packages?view=revision&revision=550524 Thanks for looking Assignee:
bugsquad =>
shlomif Hi Dimitrios, (In reply to Dimitrios Glentadakis from comment #5) > Ok, done > http://svnweb.mageia.org/packages?view=revision&revision=550524 > > Thanks for looking some comments: 1. The .spec contains some trailing whitespace. Please remove it. 2. There are some English grammatical errors in the description: <<< OpenTeacher is an opensource [should be "open source"] application that helps you [with] learning a variety of subjects. You just enter the questions and the answers, or download them from the internet, and OpenTeacher tests you. >>> Regards, -- Shlomi Fish Hi Dimitrios, (In reply to Dimitrios Glentadakis from comment #7) > Ok, done: > http://svnweb.mageia.org/packages/cauldron/openteacher/current/SPECS/ > openteacher.spec?revision=550661&view=markup thanks for the fixes. However, now rpmlint reports a few warnings: <<< rpmlint SRPMS/openteacher-3.2-1.mga4.src.rpm openteacher.src: W: no-signature openteacher.src: W: no-changelogname-tag openteacher.src:1: W: macro-in-comment %{python_sitearch} openteacher.src:1: W: macro-in-comment %{name} openteacher.src: W: description-line-too-long C OpenTeacher is an open source application that helps you with learning a variety >>> You can ignore the no-signature and no-changelog and some people think that "macro-in-comment" is not important but "description-line-too-long" *is* important. Ok done http://svnweb.mageia.org/packages/cauldron/openteacher/current/SPECS/openteacher.spec?view=log I added a patch to remove the line Version=3.2 from desktop file Here: Version = Version of Desktop Entry Specification (While the version field is not required to be present, it should be in all newer implementations of the Desktop Entry Specification. If the version number is not present, a "pre-standard" desktop entry file is to be assumed). http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-0.9.5.html it seems it indicates the program version (openteacher 3.2) and not the Version of Desktop Entry Specification Thanks looks fine - submitted - http://pkgsubmit.mageia.org/ . Regards, -- Shlomi Fish Thanks ! :) Resolution:
(none) =>
FIXED |