Bug 1119

What if a user selects Oxygen for KDE apps, but wants GTK+ apps to use the default GTK theme, ia_ora-gnome, or another GTK+ theme?

To elaborate, I agree that it should be an opt-out, i.e. user selects Oxygen style in systemsettings -> everything is Oxygen. But there should be an easy way to opt-out, here're a situation:
- oxygen-gtk is installed on the system, user A wants to use it but user B wants to use another GTK+ theme (the default ia_ora-gnome or any other theme).

(I can't read code that well, so can't answer those questions myself :)).

(In reply to comment #1)
> What if a user selects Oxygen for KDE apps, but wants GTK+ apps to use the
> default GTK theme, ia_ora-gnome, or another GTK+ theme?

oxygen-gtk is used by default only if the user has not defined another gtk style, eg by gtk-qt-kcm for us (if ~/.gtkrc-2.0-kde exists, oxygen-gtk is not used automatically).
You can see exactly when oxygen-gtk is not used automatically in the diff
https://git.reviewboard.kde.org/r/101151/diff/#3.13
line 273 to 287.

(In reply to comment #2)
> To elaborate, I agree that it should be an opt-out, i.e. user selects Oxygen
> style in systemsettings -> everything is Oxygen. But there should be an easy
> way to opt-out, here're a situation:
> - oxygen-gtk is installed on the system, user A wants to use it but user B
> wants to use another GTK+ theme (the default ia_ora-gnome or any other theme).
> 
> (I can't read code that well, so can't answer those questions myself :)).

user B just needs to use gtk-qt-kcm (or kcm-gtk on some distros) and sets the theme he wants for gtk apps, and oxygen-gtk will not be set in ~/.kde4/share/config/gtkrc-2.0

Then, I think oxygen-gtk should require, instead of only suggesting, gtk-qt-kcm.

(Though I have two gripes with that:
- oxgyen-gtk doesn't really need gtk-qt-kcm to work
- gtk-qt-kcm has an entry/button that should "fix firefox scroll bars, which edits ~/.mozilla/firefox/<profile>/chrome/userChrome.css, this isn't needed with oxygen-gtk).

(In reply to comment #5)
> Then, I think oxygen-gtk should require, instead of only suggesting,
> gtk-qt-kcm.
> 

why? 
we do exactly the same with iaora and xsettings-kde; if widgetStyle=iaorakde, xsettings-kde automatically sets iaora for gtk apps. And kde4-style-iaora-common doesn't suggest gtk-qt-kcm !!

btw, IIRC, Fedora, Kubuntu and OpenSuse use (or will use for next release) oxygen+oxygen-gtk by default.

I just want to be sure there's an easy opt-out way... but you're right (users who use themes other than the ia_ora-gnome know how to get around).

If ~/.kde4/share/config/gtkrc-2.0 is used, that means "apply colors to non-kde4 applications" in the colors kcm will have effect? (AFAICS, when it's enabled it copies /var/lib/mageia/kde4-profiles/common/share/config/gtkrc-2.0 to ~/.kde4/share/config/).

(In reply to comment #7)
> 
> If ~/.kde4/share/config/gtkrc-2.0 is used, that means "apply colors to non-kde4
> applications" in the colors kcm will have effect?

no, "apply colors to non-kde4 applications" (=KRdbExportColors) and KRdbExportGtkTheme write data for gtk apps in the same files ~/.kde4/share/config/gtkrc and ~/.kde4/share/config/gtkrc-2.0, but are distincts.
The theme oxygen-gtk automatically uses same colors as kde for gtk apps by itself, regardless of "apply colors to non-kde4 applications".

> (AFAICS, when it's enabled it
> copies /var/lib/mageia/kde4-profiles/common/share/config/gtkrc-2.0 to
> ~/.kde4/share/config/).

no, ~/.kde4/share/config/gtkrc-2.0 isn't copied from /var/lib/mageia/kde4-profiles/..., but is written from scratch by createGtkrc(...) in krdb.cpp, when kde start or when colors are changed in systemsettings.

You're right, sorry for the noise..

Patch is added for the next kdebase4-workspace.
Thks for the patch

Status: NEW => RESOLVED
Resolution: (none) => FIXED