| Summary: | Add new rpm grooveoff | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Dimitrios Glentadakis <dglent> |
| Component: | New RPM package request | Assignee: | Shlomi Fish <shlomif> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | ||
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| URL: | http://svnweb.mageia.org/packages/cauldron/grooveoff/current/SPECS/grooveoff.spec | ||
| Whiteboard: | |||
| Source RPM: | CVE: | ||
| Status comment: | |||
| Attachments: | The spec file for the rpm | ||
|
Description
Dimitrios Glentadakis
2013-08-24 09:31:20 CEST
Dimitrios Glentadakis
2013-08-24 09:33:45 CEST
URL:
(none) =>
http://svnweb.mageia.org/packages/cauldron/grooveoff/current/SPECS/grooveoff.spec you have commits right, but also a mentor to review and push these packages ?
Dimitrios Glentadakis
2013-08-25 14:16:07 CEST
Assignee:
bugsquad =>
oliver.bgr
Dimitrios Glentadakis
2013-11-12 05:50:55 CET
Assignee:
oliver.bgr =>
shlomif Hi Dimitrios, can you import the package into the SVN? It is already imported, see in the URL field Probably i have to fix it a little bit, the size of the sescription and the Requires with %lib i will change it to a noarch requires Finaly the description seems ok for me. I changed the Requires: http://svnweb.mageia.org/packages/cauldron/grooveoff/current/SPECS/grooveoff.spec?r1=470908&r2=550745 i will verify the Requires as the application produces mp3 files Hi Dimitrios, sorry for the late response, but I didn't register your "It is already imported" reply.
Anyway, here are my comments:
1. There's a mix use of tabs and spaces (reported by rpmlint) - please convert it to 100% spaces (you can use vim/gvim's retab command).
2. There's trailing whitespace on one line.
3. "a public api" should be "a public API".
4. The description reads in first person, and is also not a grammatical. It also includes some information that is of no interest to someone who is installing the package.
Here is how I'll rephrase it:
<<<<<<<<<<<<<
GrooveOff is an unofficial client for grooveshark.com.
Using it, it is possible to search grooveshark.com's huge database
(thanks to its public API) for artists, songs and albums and save them
on disk for offline playing.
GrooveOff provides some easy to use filters based on artists and albums.
Also included is a minimal player for previewing and listening to songs,
so one will be able to decide whether to keep or reject them. The
application is based on the Qt toolkit, but should feel native in
all desktop environments.
>>>>>>>>>>>>>
Regards,
-- Shlomi Fish
ok done: http://svnweb.mageia.org/packages?view=revision&revision=550914 for me it is ok now I just forgot to mention in the svn log that i removed the trailing whitespace too. You now have some trailing whitespace in a different line. Please remove it. Otherwise looks fine. Baah sorry :) ok: http://svnweb.mageia.org/packages/cauldron/grooveoff/current/SPECS/grooveoff.spec?r1=550914&r2=551122 Hi Dimitrios, (In reply to Dimitrios Glentadakis from comment #11) > Baah sorry :) ok: > http://svnweb.mageia.org/packages/cauldron/grooveoff/current/SPECS/grooveoff. > spec?r1=550914&r2=551122 Submitted, thanks. Its me ! Status:
NEW =>
RESOLVED |