Bug 10925

Summary:	putty/filezilla - SSH handshake heap overflow (CVE-2013-4852, CVE-2013-4206, CVE-2013-4207, CVE-2013-4208)
Product:	Mageia	Reporter:	Oden Eriksson <oe>
Component:	Security	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:	Sec team <security>
Severity:	major
Priority:	Normal	CC:	davidwhodgins, geiger.david68210, luigiwalser, mageia, mageia, sysadmin-bugs, tmb, wilcal.int
Version:	3	Keywords:	validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
URL:	http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-4852
Whiteboard:	MGA2TOO MGA2-32-OK MGA2-64-OK MGA3-32-OK MGA3-64-OK
Source RPM:	putty, filezilla	CVE:
Status comment:

Description Oden Eriksson 2013-08-05 11:36:39 CEST

http://www.search-lab.hu/advisories/secadv-20130722

"
Description: PuTTY versions 0.62 and earlier - as well as all software that 
integrates these versions of PuTTY - are vulnerable to an integer overflow 
leading to heap overflow during the SSH handshake before authentication, caused 
by improper bounds checking of the length parameter received from the SSH server.
This allows  remote attackers to cause denial of service, and may have more 
severe impact on the operation of software that uses PuTTY code.

Affected software products: 
- PuTTY up to and including 0.62 
- WinSCP before 5.1.6
- all other software that uses vulnerable (revision 9895 or earlier) PuTTY code


Details: 
A malformed size value in the SSH handshake could cause an integer overflow, as 
the getstring() function in sshrsa.c and sshdss.c read the handshake message 
length without checking that it was not a negative number.

Specifically, the bignum_from_bytes() function invoked by getstring() received a 
data buffer along with its length represented by a signed integer (nbytes) and 
performed the following arithmetical operation before allocating memory to store 
the buffer:

    w = (nbytes + BIGNUM_INT_BYTES - 1) / BIGNUM_INT_BYTES; /* bytes->words */ 
    result = newbn(w);

If the value of nbytes was -1 (0xffffffff), the value of w would overflow to a 
very small positive number (depending on the value of BIGNUM_INT_BYTES), causing 
newbn() to reserve a very small memory area. Then a large number of bytes would 
be copied into the data buffer afterwards, resulting in a heap overflow.

Similarly, if nbytes was chosen so that w would be -1, the newbn() function 
would allocate zero bytes in memory via snewn() and attempt to write the size of 
the Bignum (in four bytes) into the allocated zero-byte area, also resulting in 
a heap overflow.


Consequences: 
In the standalone PuTTY client the attacker does not have precise control over 
the memory corruption, so this bug can only cause a local denial-of-service 
(crash). However, in other software that uses PuTTY code, such heap corruption 
could have more severe effects. Specifically in case of WinSCP, this 
vulnerability could potentially lead to code execution due to the exception 
handling employed by the program.


Solution: 
This vulnerability has been fixed in the development version of PuTTY [2]. All
developers using PuTTY code are recommended to use revision 9896 or later. 
The potential code execution vulnerability has been addressed in WinSCP 5.1.6 
[3].


Credits: 
This vulnerability was discovered and researched by Gergely Eberhardt 
from SEARCH-LAB Ltd. (www.search-lab.hu)


References: 
[1] http://www.search-lab.hu/advisories/secadv-20130722
[2] http://svn.tartarus.org/sgt?view=revision&sortby=date&revision=9896 
[3] http://winscp.net/tracker/show_bug.cgi?id=1017
"


Reproducible: 

Steps to Reproduce:

Comment 1 Oden Eriksson 2013-08-05 11:37:04 CEST

Fixed packages has been submitted to all.

Sander Lepik 2013-08-05 11:57:54 CEST

CC: (none) => mageia
Hardware: i586 => All
Version: 2 => 3
Whiteboard: (none) => MGA3TOO

Comment 2 Sander Lepik 2013-08-05 11:58:21 CEST

Sorry, wrong version.

Whiteboard: MGA3TOO => MGA2TOO

Comment 3 David Walser 2013-08-05 19:47:42 CEST

And here I thought PuTTY was just a Windows program.

Advisory:
========================

Updated putty packages fix security vulnerability:

PuTTY versions 0.62 and earlier - as well as all software that integrates these
versions of PuTTY - are vulnerable to an integer overflow leading to heap
overflow during the SSH handshake before authentication, caused by improper
bounds checking of the length parameter received from the SSH server. This
allows remote attackers to cause denial of service, and may have more severe
impact on the operation of software that uses PuTTY code (CVE-2013-4852).

References:
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-4852
http://www.search-lab.hu/advisories/secadv-20130722
========================

Updated packages in core/updates_testing:
========================
putty-0.62-1.1.mga2
putty-0.62-2.1.mga3

from SRPMS:
putty-0.62-1.1.mga2.src.rpm
putty-0.62-2.1.mga3.src.rpm

CC: (none) => luigiwalser
Assignee: bugsquad => qa-bugs
Summary: CVE-2013-4852: putty - SSH handshake heap overflow => putty - SSH handshake heap overflow (CVE-2013-4852)

Comment 4 David Walser 2013-08-05 23:06:17 CEST

Oden, as you probably saw here, filezilla may also be affected:
http://openwall.com/lists/oss-security/2013/08/05/6

Could you patch that package as well if need be?

Comment 5 Dave Hodgins 2013-08-06 03:42:26 CEST

Advisory 10925.adv uploaded to svn.

CC: (none) => davidwhodgins

Comment 6 Oden Eriksson 2013-08-06 08:50:44 CEST

http://www.openwall.com/lists/oss-security/2013/08/05/6

filezilla embeds putty, so i just submitted filezilla-3.5.3-1.1.mga2, filezilla-3.6.0.2-2.1.mga3 and filezilla-3.7.1.1-2.mga4.

Comment 7 David Walser 2013-08-06 20:32:13 CEST

Thanks Oden!  Adding filezilla to the advisory (Dave, please update in SVN).

Advisory:
========================

Updated putty and filezilla packages fix security vulnerability:

PuTTY versions 0.62 and earlier - as well as all software that integrates these
versions of PuTTY - are vulnerable to an integer overflow leading to heap
overflow during the SSH handshake before authentication, caused by improper
bounds checking of the length parameter received from the SSH server. This
allows remote attackers to cause denial of service, and may have more severe
impact on the operation of software that uses PuTTY code (CVE-2013-4852).

References:
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-4852
http://www.search-lab.hu/advisories/secadv-20130722
========================

Updated packages in core/updates_testing:
========================
putty-0.62-1.1.mga2
filezilla-3.5.3-1.1.mga2
putty-0.62-2.1.mga3
filezilla-3.6.0.2-2.1.mga3

from SRPMS:
putty-0.62-1.1.mga2.src.rpm
filezilla-3.5.3-1.1.mga2.src.rpm
putty-0.62-2.1.mga3.src.rpm
filezilla-3.6.0.2-2.1.mga3.src.rpm

Summary: putty - SSH handshake heap overflow (CVE-2013-4852) => putty/filezilla - SSH handshake heap overflow (CVE-2013-4852)

David Walser 2013-08-06 20:32:22 CEST

Source RPM: putty => putty, filezilla

Comment 8 David Walser 2013-08-06 22:54:46 CEST

There may be some additional fixes needed:
http://openwall.com/lists/oss-security/2013/08/06/11

Comment 9 Dave Hodgins 2013-08-07 01:38:33 CEST

Advisory 10925.adv modified to include filezilla srpms.

Adding the feedback whiteboard entry until comment 8 is replied to.

Whiteboard: MGA2TOO => MGA2TOO feedback

Comment 10 Oden Eriksson 2013-08-07 10:37:24 CEST

Sorry guys, putty has some more issues. I just submitted 0.63 that fixes CVE-2013-4852, CVE-2013-4206, CVE-2013-4207, CVE-2013-4208.

Reference:

http://www.openwall.com/lists/oss-security/2013/08/06/13

Oden Eriksson 2013-08-07 10:38:02 CEST

Summary: putty/filezilla - SSH handshake heap overflow (CVE-2013-4852) => putty/filezilla - SSH handshake heap overflow (CVE-2013-4852, CVE-2013-4206, CVE-2013-4207, CVE-2013-4208)

Comment 11 claire robinson 2013-08-07 10:52:59 CEST

Does filezilla need rebuilding too?

Comment 12 Oden Eriksson 2013-08-07 11:40:09 CEST

3.7.2 was released yesterday that fixed CVE-2013-4852, so I think they will fix the other ones soon.

filezilla uses it's own bundled copy of putty.

Will see if I manage to patch the other CVEs there.

Comment 13 Oden Eriksson 2013-08-07 11:50:00 CEST

Ouch, too painful for me to patch filezilla. Maybe someone else has the time, or we just wait for 3.7.3?

Comment 14 Oden Eriksson 2013-08-07 12:18:30 CEST

Reported upstream: http://trac.filezilla-project.org/ticket/8826

Comment 15 David Walser 2013-08-07 20:05:52 CEST

Damien has built filezilla-3.7.2-1.mga4 for Cauldron.  I guess it just needs backported to mga2 and mga3 now.

CC: (none) => mageia

Comment 16 Oden Eriksson 2013-08-08 10:31:45 CEST

filezilla-3.7.3 has been submitted to all.

- 3.7.3 (fixes CVE-2013-4206, CVE-2013-4207, CVE-2013-4208)
- 3.7.2 (fixes CVE-2013-4852)

Comment 17 David Walser 2013-08-08 13:57:07 CEST

Advisory:
========================

Updated putty and filezilla packages fix security vulnerabilities:

PuTTY versions 0.62 and earlier - as well as all software that integrates these
versions of PuTTY - are vulnerable to an integer overflow leading to heap
overflow during the SSH handshake before authentication, caused by improper
bounds checking of the length parameter received from the SSH server. This
allows remote attackers to cause denial of service, and may have more severe
impact on the operation of software that uses PuTTY code (CVE-2013-4852).

PuTTY versions 0.62 and earlier - as well as all software that integrates these
versions of PuTTY - are vulnerable to a heap-corrupting buffer underrun bug in
the modmul function which performs modular multiplication (CVE-2013-4206).

PuTTY versions 0.62 and earlier - as well as all software that integrates these
versions of PuTTY - are vulnerable to a buffer overflow vulnerability in the
calculation of modular inverses when verifying a DSA signature (CVE-2013-4207).

PuTTY versions 0.62 and earlier - as well as all software that integrates these
versions of PuTTY - are vulnerable to private keys left in memory after being
used by PuTTY tools (CVE-2013-4208).

References:
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-4206
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-4207
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-4208
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-4852
http://www.chiark.greenend.org.uk/~sgtatham/putty/wishlist/vuln-modmul.html
http://www.chiark.greenend.org.uk/~sgtatham/putty/wishlist/vuln-bignum-division-by-zero.html
http://www.chiark.greenend.org.uk/~sgtatham/putty/wishlist/private-key-not-wiped.html
http://www.openwall.com/lists/oss-security/2013/08/06/13
http://www.search-lab.hu/advisories/secadv-20130722
========================

Updated packages in core/updates_testing:
========================
putty-0.63-1.mga2
filezilla-3.7.3-1.mga2
putty-0.63-1.mga3
filezilla-3.7.3-1.mga3

from SRPMS:
putty-0.63-1.mga2.src.rpm
filezilla-3.7.3-1.mga2.src.rpm
putty-0.63-1.mga3.src.rpm
filezilla-3.7.3-1.mga3.src.rpm

Whiteboard: MGA2TOO feedback => MGA2TOO

David Walser 2013-08-08 19:20:49 CEST

Severity: normal => major

Comment 18 David GEIGER 2013-08-08 19:34:08 CEST

Testing complete mga3_64 for filezilla 3.7.3-1, ok for me nothing to report.

CC: (none) => geiger.david68210

Comment 19 David GEIGER 2013-08-08 19:34:22 CEST

Testing complete mga3_32 for filezilla 3.7.3-1, ok for me nothing to report.

Comment 20 William Kenney 2013-08-08 20:10:11 CEST

MGA3-32-OK

in VirtualBox

default install putty-0.62-2.mga3.i586 from core release
[root@localhost wilcal]# urpmi putty
Package putty-0.62-2.mga3.i586 is already installed
default install filezilla-3.6.0.2-2.mga3.i586 from core release
[root@localhost wilcal]# urpmi filezilla
Package filezilla-3.6.0.2-2.mga3.i586 is already installed

Opened Filezilla transferred files from M3 and Rasberry Pi servers on my LAN.
Opened Putty, opened terminal and listed files on an M3 and Rasberry Pi servers on my LAN

install putty-0.63-1.mga3.i586 from core updates_testing
[root@localhost wilcal]# urpmi putty
Package putty-0.63-1.mga3.i586 is already installed
install filezilla-3.7.3-1.mga3.i586 from core updates_testing
[root@localhost wilcal]# urpmi filezilla
Package filezilla-3.7.3-1.mga3.i586 is already installed
Rerun testing with the same above servers. All successful

Test platform:
Intel Core i7-2600K Sandy Bridge 3.4GHz
GIGABYTE GA-Z68X-UD3-B3 LGA 1155 MoBo
GIGABYTE GV-N440D3-1GI Nvidia GeForce GT 440 (Fermi) 1GB
RTL8111/8168B PCI Express 1Gbit Ethernet
DRAM 16GB (4 x 4GB)
VirtualBox 4.2.16-1.mga3.x86_64.rpm

CC: (none) => wilcal.int

Comment 21 William Kenney 2013-08-08 20:10:53 CEST

MGA3-64-OK

in VirtualBox

default install putty-0.62-2.mga3.x86_64 from core release
[root@localhost wilcal]# urpmi putty
Package putty-0.62-2.mga3.x86_64 is already installed
default install filezilla-3.6.0.2-2.mga3.x86_64 from core release
[root@localhost wilcal]# urpmi filezilla
Package filezilla-3.6.0.2-2.mga3.x86_64 is already installed

Opened Filezilla transferred files from M3 and Rasberry Pi servers on my LAN.
Opened Putty, opened terminal and listed files on an M3 and Rasberry Pi servers on my LAN

install putty-0.63-1.mga3.x86_64 from core updates_testing
[root@localhost wilcal]# urpmi putty
Package putty-0.63-1.mga3.x86_64 is already installed
install filezilla-3.7.3-1.mga3.x86_64 from core updates_testing
[root@localhost wilcal]# urpmi filezilla
Package filezilla-3.7.3-1.mga3.x86_64 is already installed
Rerun testing with the same above servers. All successful

Test platform:
Intel Core i7-2600K Sandy Bridge 3.4GHz
GIGABYTE GA-Z68X-UD3-B3 LGA 1155 MoBo
GIGABYTE GV-N440D3-1GI Nvidia GeForce GT 440 (Fermi) 1GB
RTL8111/8168B PCI Express 1Gbit Ethernet
DRAM 16GB (4 x 4GB)
VirtualBox 4.2.16-1.mga3.x86_64.rpm

Whiteboard: MGA2TOO => MGA2TOO MGA3-32-OK MGA3-64-OK

Comment 22 William Kenney 2013-08-08 21:07:21 CEST

MGA2-32-OK

in VirtualBox

default install putty-0.62-1.mga2.i586 from core release
[root@localhost wilcal]# urpmi putty
Package putty-0.62-1.mga2.i586 is already installed
default install filezilla-3.5.3-1.mga2.i586 from core release
[root@localhost wilcal]# urpmi filezilla
Package filezilla-3.5.3-1.mga2.i586 is already installed

Opened Filezilla transferred files from M3 and Rasberry Pi servers on my LAN.
Opened Putty, opened terminal and listed files on an M3 and Rasberry Pi servers on my LAN

install putty-0.63-1.mga2.i586 from core updates_testing
[root@localhost wilcal]# urpmi putty
Package putty-0.63-1.mga2.i586 is already installed
install filezilla-3.7.3-1.mga2.i586 from core updates_testing
[root@localhost wilcal]# urpmi filezilla
Package filezilla-3.7.3-1.mga2.i586 is already installed
Rerun testing with the same above servers. All successful

Test platform:
Intel Core i7-2600K Sandy Bridge 3.4GHz
GIGABYTE GA-Z68X-UD3-B3 LGA 1155 MoBo
GIGABYTE GV-N440D3-1GI Nvidia GeForce GT 440 (Fermi) 1GB
RTL8111/8168B PCI Express 1Gbit Ethernet
DRAM 16GB (4 x 4GB)
VirtualBox 4.2.16-1.mga3.x86_64.rpm

Comment 23 William Kenney 2013-08-08 21:08:27 CEST

MGA2-64-OK

in VirtualBox

default install putty-0.62-1.mga2.x86_64 from core release
[root@localhost wilcal]# urpmi putty
Package putty-0.62-1.mga2.x86_64 is already installed
default install filezilla-3.5.3-1.mga2.x86_64 from core release
[root@localhost wilcal]# urpmi filezilla
Package filezilla-3.5.3-1.mga2.x86_64 is already installed

Opened Filezilla transferred files from M3 and Rasberry Pi servers on my LAN.
Opened Putty, opened terminal and listed files on an M3 and Rasberry Pi servers on my LAN

install putty-0.63-1.mga2.x86_64 from core updates_testing
[root@localhost wilcal]# urpmi putty
Package putty-0.63-1.mga2.x86_64 is already installed
install filezilla-3.7.3-1.mga2.x86_64 from core updates_testing
[root@localhost wilcal]# urpmi filezilla
Package filezilla-3.7.3-1.mga2.x86_64 is already installed
Rerun testing with the same above servers. All successful

Test platform:
Intel Core i7-2600K Sandy Bridge 3.4GHz
GIGABYTE GA-Z68X-UD3-B3 LGA 1155 MoBo
GIGABYTE GV-N440D3-1GI Nvidia GeForce GT 440 (Fermi) 1GB
RTL8111/8168B PCI Express 1Gbit Ethernet
DRAM 16GB (4 x 4GB)
VirtualBox 4.2.16-1.mga3.x86_64.rpm

Whiteboard: MGA2TOO MGA3-32-OK MGA3-64-OK => MGA2TOO MGA2-32-OK MGA2-64-OK MGA3-32-OK MGA3-64-OK

William Kenney 2013-08-08 21:13:05 CEST

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs

Comment 24 William Kenney 2013-08-08 21:13:32 CEST

Validating the update.
Could someone from the sysadmin team push 10925.adv to updates.

Comment 25 Dave Hodgins 2013-08-09 00:33:07 CEST

Advisory 10925.adv updated in svn to reflect comment 17.
Please push 10925.adv to updates.

Comment 26 Thomas Backlund 2013-08-09 19:39:13 CEST

Update pushed:
http://advisories.mageia.org/MGASA-2013-0242.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED

Comment 27 David Walser 2013-08-21 22:11:06 CEST

This also fixes CVE-2011-4607:
http://lwn.net/Vulnerabilities/564256/