Bug 10598

Summary:	xdg_menu produces bad XML for Openbox
Product:	Mageia	Reporter:	Derek Jennings <derekjenn>
Component:	RPM Packages	Assignee:	D Morgan <dmorganec>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	jani.valimaa, mageia
Version:	Cauldron	Keywords:	PATCH
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	desktop-common-data-3.3-1.mga.src.rpm	CVE:
Status comment:
Attachments:	Fix XML for Openbox

Description Derek Jennings 2013-06-23 12:48:35 CEST

While working on a fix for Bug 7340 to provide dynamic xdg menus for Openbox I found that the script xdg_menu which produces the dynamic menus outputs bad xml for Openbox

When called with 'xdg_menu --format openbox3'  the xml produced does not have menu start and end tags, and the menu ids are not unique so a submenu with the title 'More' will have the same id as the other submenus of the same name.

The lack of start and end tags causes openbox to reject the menu, and if the tags are added manually the non unique id means that all but the first instance of the 'More' submenu are rejected.

I have a patch for xdg_menu to fix the openbox xml, but as an apprentice packager I do not want to commit to a package assigned to someone else with impact on other desktops.

Reproducible: 

Steps to Reproduce:

Comment 1 Derek Jennings 2013-06-23 12:52:37 CEST

Created attachment 4156 [details]
Fix XML for Openbox

This patch puts menu start and end tags around the output of 'xdg_menu --format openbox3', and makes the menu ids unique by catenating the submenu title with its parent.

Derek Jennings 2013-06-23 13:00:57 CEST

Keywords: (none) => PATCH

Sander Lepik 2013-06-23 13:10:30 CEST

CC: (none) => mageia
Assignee: bugsquad => dmorganec

Comment 2 Jani Välimaa 2013-06-24 17:39:36 CEST

Patched xdg_menu in $SVN/soft and pushed new version.

Status: NEW => RESOLVED
CC: (none) => jani.valimaa
Resolution: (none) => FIXED