Bug 10458

Summary:	add systemd/dbus support to drakkeyboard
Product:	Mageia	Reporter:	Pablo Saratxaga <pablo>
Component:	RPM Packages	Assignee:	Mageia tools maintainers <mageiatools>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	Normal	CC:	basesystem, mageia, marja11, pablo, thierry.vignaud
Version:	Cauldron	Keywords:	PATCH
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	drakx-kbd-mouse-x11	CVE:
Status comment:
Attachments:	patch that adds systemd (localectl keyboard info) support to drakkeyboard patch that adds systemd (localectl keyboard info) support to drakkeyboard

Description Pablo Saratxaga 2013-06-08 02:41:12 CEST

Nowadays configuration tools use d-bus services to tell about the changes they do; so all tools can cooperate.

for keyboard configuration there is a systemd service.

drakkeyboard should use it.

Reproducible: 

Steps to Reproduce:

Comment 1 Pablo Saratxaga 2013-06-08 02:46:38 CEST

Created attachment 4114 [details]
patch that adds systemd (localectl keyboard info) support to drakkeyboard

This patch makes drakkeyboard use systemd service tool localectl to read/write the keyboard info.

Pablo Saratxaga 2013-06-08 03:10:02 CEST

Keywords: (none) => PATCH

Pablo Saratxaga 2013-06-08 03:10:11 CEST

CC: (none) => pablo

Comment 2 Pablo Saratxaga 2013-06-08 03:12:35 CEST

Created attachment 4115 [details]
patch that adds systemd (localectl keyboard info) support to drakkeyboard

oups; this is the correct patch

Attachment 4114 is obsolete: 0 => 1

Manuel Hiebel 2013-06-08 16:22:58 CEST

Assignee: bugsquad => thierry.vignaud
Source RPM: libdrakx-kbd-mouse-x11 => drakx-kbd-mouse-x11

Comment 3 Thierry Vignaud 2013-12-27 16:33:16 CET

Colin, what do you think?

CC: (none) => mageia

Comment 4 Colin Guthrie 2013-12-27 16:46:01 CET

(In reply to Thierry Vignaud from comment #3)
> Colin, what do you think?

Great start :)

Some comments:

 1. We should really just use dbus directly and not use the command line utils (which are themselves dbus clients) and parse the output.

 2. We need to watch that we do not run these utils during the install as the system is not yet available.

Long term I'd like to see the installer "start" a container of the installed system and then run dbus utilities inside the container (thus reading/writing from the correct backend configs), but this is not something I was able to do this time round.

Anyway, provided we don't have a problem in the installer with this (and looking at the patch the lack of $::prefix usage in the binary name would seem we will not do this - unless localectl sneaks into the installer somehow... - I don't think I've pushed it there yet - but perhaps a comment in the code to clarify that it's a non-installer path for future reference would be wise)

Also, I wonder if it's not worth always running the fallback code anyway (e.g. always writing to /etc/sysconfig/keyboard even if localectl is there and found) just in case(tm)...

Longer term we should deprecate the whole /etc/sysconfig/keyboard thing, but we're probably not quite ready yet.

Comment 5 Samuel Verschelde 2015-04-23 13:46:36 CEST

Has there been progress outside this bug report, or is comment #4 the latest state of it?

Keywords: (none) => NEEDINFO

Comment 6 Marja Van Waes 2017-09-10 18:08:53 CEST

(In reply to Samuel Verschelde from comment #5)
> Has there been progress outside this bug report, or is comment #4 the latest
> state of it?

I can't find that anything happened since then.

Re-assigning to the mageiatools maintainers and CC'ing the basesystem maintainers.

Note that the patch can't be used as is (Colin had some comments on it, and keyboard.pm may have changed too much, anyway).

Assignee: thierry.vignaud => mageiatools
CC: (none) => basesystem, marja11, thierry.vignaud
Keywords: NEEDINFO => (none)