| Summary: | drakx* should add "nofail" option to "foreign" mountpoints to avoid unwanted recovery mode (was: Can't boot Mageia 3 after complete install) | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Peter Landgren <peter.talken> |
| Component: | Installer | Assignee: | Pascal Terjan <pterjan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | release_blocker | CC: | brahmbeus, doktor5000, eeeemail, ennael1, hhielscher, laidlaws, mageia, mageia, mageia, mahecha, marja11, rverschelde, sat, stormi-mageia, superaphke, thierry.vignaud, tmb, zen25000 |
| Version: | Cauldron | Keywords: | PATCH |
| Target Milestone: | Mageia 5 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://bugs.mageia.org/show_bug.cgi?id=4042 https://bugs.mageia.org/show_bug.cgi?id=12631 |
||
| Whiteboard: | |||
| Source RPM: | CVE: | ||
| Status comment: | |||
| Attachments: | Patch to add nofail option when diskdrake writes /etc/fstab | ||
|
Description
Peter Landgren
2013-05-20 15:24:06 CEST
Try to comment those partitions out in /etc/fstab - will that help? Not sure if rescue has any editors tho'. You might need to use LiveCD/DVD. CC:
(none) =>
sander.lepik But how do I change fstab. It seems to read only when I run the LiveDVD and load into an editor. Run LiveDVD, mount your root partition, search for /etc/fstab from that partition and edit it. (In reply to Peter Landgren from comment #2) > But how do I change fstab. It seems to read only when I run the LiveDVD and > load into an editor. You need to use : su mkdir /mountpoint mount -t ext4 /dev/sdxy /mountpoint and: su - kwrite (or gedit) to run a root GUI editor. CC:
(none) =>
zen25000 Thanks, that helped! what is the output of fdisk -l ? CC:
(none) =>
mageia, thierry.vignaud [root@compaq1 peter]# fdisk -l
Disk /dev/sda: 320.1 GB, 320072933376 bytes, 625142448 sectors
Units = sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Diskidentifierare: 0xb7a32d9f
Enhet Start Början Slut Block Id System
/dev/sda1 * 2048 409599 203776 7 HPFS/NTFS/exFAT
/dev/sda2 417690 296045819 147814065 7 HPFS/NTFS/exFAT
/dev/sda3 296045820 594870884 149412532+ 83 Linux
/dev/sda4 594886656 625139711 15126528 7 HPFS/NTFS/exFAT
[root@compaq1 peter]#
We really should make drakx* add the "nofail" option to any "foreign" mountpoints to avoid this kind of problem.
Samuel Verschelde
2013-08-27 15:40:25 CEST
CC:
(none) =>
stormi was something like this already done ?
Florian Hubold
2014-02-07 21:56:38 CET
See Also:
(none) =>
https://bugs.mageia.org/show_bug.cgi?id=4042
Florian Hubold
2014-05-17 18:43:25 CEST
Priority:
Normal =>
release_blocker
claire robinson
2014-05-17 20:17:43 CEST
CC:
(none) =>
eeeemail, tmb This caught me again when installing/testing M5b1. It is a common problem for people dual-booting Windows 8. I see this bug is marked as a release blocker - but it's not assigned to anyone, so does it stand any chance of getting fixed? CC:
(none) =>
mageia Yikes! I just installed 5b1 and didn't think of it. I usually comment out the line in /etc/fstab. Then the USB drive behaves as a removable one, similar to other distros. (In reply to Colin Guthrie from comment #8) > We really should make drakx* add the "nofail" option to any "foreign" > mountpoints to avoid this kind of problem. @Thierry, Thomas, or anyone in CC and with some understanding of how that could be achieved: do you think Colin's idea would be the right way to go, and if so how could it be implemented? Possibly in a few non-disrupting lines of code that could make it in Mageia 5? CC:
(none) =>
remi I don't have the knowledge to make any suggestions. Ubuntu and derivatives always mount USB keys as removable. Mageia makes them permanent. Can we look at what other distros have done? At the other extreme, the XFCE DE treats all unmounted partitions as "removable" and shows them on the desktop. OpenMandriva's XFCE manages to corral them in a file manager window, but that is really a workaround. I unplug everything at install time if I remember soon enough. Then all removable media are mounted from /run/media/. Both KDE and Xfce treat them as removable. I have just purchased a Seagate 1 TB expansion drive. If I boot up with it attached, it always becomes /dev/sda. The forums are full of similar stories. Apparently, it has to do with the drive's firmware. But that is only incidental to this bug. Assigning to pterjan, because afaik he maintains the diskdrake part of drakx, and because I think diskdrake decides what should be added in /etc/fstab please re-assign if I'm wrong! CC:
(none) =>
marja11 I'd like to add my vote to this for Mageia 5. I've been succesful installing a dual-boot with Windows 8.1 by turning off Windows 'fast-boot' but this hasn't worked with Windows 10 preview and Mageia 5 beta. Also, I do wonder whether it would be better not to mount the Windows partitions (i.e. any NTFS) in fstab by default. I know people can do this manually but why make such an obvious security breach easy? CC:
(none) =>
sat prepare_write_fstab in perl-install/fs.pm has things like this:
my ($freq, $passno) =
exists $_->{freq} ?
($_->{freq}, $_->{passno}) :
isTrueLocalFS($_) && !$_->{dmcrypt_name} && $_->{options} !~ /encryption=/ && (!$_->{is_removable} || member($_->{mntpoint}, fs::type::directories_needed_to_boot())) ?
(1, $_->{mntpoint} eq '/' ? 1 : fs::type::carry_root_loopback($_) ? 0 : 2) :
(0, 0);
Sounds like a good place.
I really can't add any more. The external drive I mentioned in Comment 16 no longer makes itself /dev/sda, but it keeps unmounting itself and being no longer in the listing with "fdisk -l." That may have nothing to do with this bug. My Windows7 partition on a BIOS system works well, but my hardware is virtually obsolete. The automatically generated menu.lst produces multiple copies of the Windows option, but that is nothing new. Created attachment 5990 [details]
Patch to add nofail option when diskdrake writes /etc/fstab
This patch to fs.pm fixes this bug for me. I've tested it with a Windows-8 system partition with fast boot enabled and with a removable USB flash memory drive.
Marja Van Waes
2015-03-04 22:55:15 CET
Keywords:
(none) =>
PATCH Looks OK. Though: - "$options = $options . ',nofail';" is better written: "$options .= ',nofail'; - "'ntfs', 'ntfs-3g'" can be written: "qw(ntfs ntfs-3g)" (which shows better it's a list) commit 745849cdace7ed86ce12a9a7564bffb42edf0ef3
Author: Anne Nicolas <ennael@...>
Date: Thu Mar 5 08:47:05 2015 +0100
add "nofail" option to "foreign" mountpoints to avoid unwanted
recovery mode (Martin Whitaker) mga#10179
---
Commit Link:
http://gitweb.mageia.org/software/drakx/commit/?id=745849cdace7ed86ce12a9a7564bffb42edf0ef3
Fixed in next version of drakx* tools. Thanks Martin and Thierry Status:
NEW =>
RESOLVED stage2 does not build, there must be a typo: cd ../.. ; perl_checker -q --generate-pot share/po/libDrakX.pot *.pm c/*.pm diskdrake/*.pm harddrake/*.pm interactive/*.pm modules/*.pm partition_table/*.pm resize_fat/*.pm security/*.pm fs/*.pm fs/remote/*.pm File "fs.pm", line 337, character 30-672 Unterminated_string Makefile:29: recipe for target 'libDrakX.pot' failed Status:
RESOLVED =>
REOPENED Indeed Anne copy-pasted the double quote from Thierry's example, I'll fix. commit fe78f2a38c4a9cd3d7802b0b2ee323aaaaf82a6a
Author: Rémi Verschelde <remi@...>
Date: Thu Mar 5 11:02:00 2015 +0100
Fix typo (mga#10179)
---
Commit Link:
http://gitweb.mageia.org/software/drakx/commit/?id=fe78f2a38c4a9cd3d7802b0b2ee323aaaaf82a6a
Now fixed in drakxtools 16.66 and drakx-installer-stage2 16.66. Status:
REOPENED =>
RESOLVED |