Bug 10116

Summary: Diskdrake fails to format a btrfs partitions if bad block check is ticked
Product: Mageia Reporter: Barry Jackson <zen25000>
Component: InstallerAssignee: Thierry Vignaud <thierry.vignaud>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: High CC: ennael1, olivier, thierry.vignaud, tmb
Version: Cauldron   
Target Milestone: ---   
Hardware: i586   
OS: Linux   
Whiteboard: MGA3TOO,
Source RPM: CVE:
Status comment:

Description Barry Jackson 2013-05-15 23:36:11 CEST
Description of problem:

Formatting partitions to btrfs fails with: An error occured: btrfs formatting of sda1 failed.
(testing Mageia-3-LiveDVD-GNOME-i586-DVD.iso [Wed May 15 01:15:00 CEST 2013] in VBox)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Boot Live DVD directly into installer
2. Select custom partitioning
3. Create / swap and /home and select btrfs for / and /home
4. Error occurs when partitioning.


Reproducible: 

Steps to Reproduce:
Comment 1 Barry Jackson 2013-05-16 00:05:55 CEST
Running diskdrake in the live DVD and attempting to format a partition to btrfs produces:-

mkfs.btrfs: invalid option -- 'c'
usage: mkfs.btrfs [options] dev [ dev ... ]
options:
	 -A --alloc-start the offset to start the FS
	 -b --byte-count total number of bytes in the FS
	 -d --data data profile, raid0, raid1, raid10, dup or single
	 -l --leafsize size of btree leaves
	 -L --label set a label
	 -m --metadata metadata profile, values like data profile
	 -M --mixed mix metadata and data together
	 -n --nodesize size of btree nodes
	 -s --sectorsize min block allocation
	 -r --rootdir the source directory
	 -K --nodiscard do not perform whole device TRIM
	 -V --version print the mkfs.btrfs version and exit
Btrfs v0.20-rc1
Barry Jackson 2013-05-16 00:08:17 CEST

Priority: Normal => High

Comment 2 Manuel Hiebel 2013-05-16 22:34:32 CEST
a release_blocker I would say

Priority: High => release_blocker
CC: (none) => ennael1, thierry.vignaud, tmb
Version: 3 => Cauldron

Comment 3 Barry Jackson 2013-05-17 00:03:44 CEST
I have done some tests in live kde4 CD on a real system attempting to format newly created partitions with diskdrake to btrfs.

Running /usr/sbin/diskdrake from terminal I can create one partition and format it OK, however if I create a second partition, the second format fails with:

error checking /dev/sdc11 mount status

Formatting the second partition to ext4 works OK.
Comment 4 Barry Jackson 2013-05-17 01:00:42 CEST
By creating the following in the live installer:
/boot ext2  sdc12
/     btrfs sdc10
/home ext4  sdc11

and using grub2 as bootloader installed to /boot

The system installs and boots without issue.


So - it seems that diskdrake cannot format more than one partition to btrfs from a live CD.
Barry Jackson 2013-05-17 01:01:50 CEST

Summary: Diskdrake in live installer fails to format to btrfs => Diskdrake in live installer fails to format two btrfs partitions

Comment 5 Manuel Hiebel 2013-12-05 21:47:19 CET
Changing version, it will be great to test if mga4 state is better (and add
back to cauldron if it's still valid).

Priority: release_blocker => High
Version: Cauldron => 3

Olivier FAURAX 2014-01-12 18:11:11 CET

CC: (none) => olivier

Comment 6 Olivier FAURAX 2014-01-12 18:26:20 CET
The -c seems to be when mkfs tries to check for erroneous blocks...
Comment 7 Manuel Hiebel 2014-01-12 23:53:24 CET
*** Bug 12276 has been marked as a duplicate of this bug. ***
Comment 8 Manuel Hiebel 2014-01-12 23:56:54 CET
adding btrfs here http://gitweb.mageia.org/software/drakx/tree/perl-install/fs/partitioning.pm#n55 could be enough no ?

Version: 3 => Cauldron
Assignee: bugsquad => thierry.vignaud
Summary: Diskdrake in live installer fails to format two btrfs partitions => Diskdrake fails to format a btrfs partitions if bad block check is ticked
Whiteboard: (none) => MGA3TOO,

Comment 9 Thierry Vignaud 2014-01-13 06:36:58 CET
Fixed in git

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 10 Mageia Robot 2014-01-13 06:37:13 CET
commit 29d9934ca3d8493b249efc6b883590fdbc08408a
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Mon Jan 13 06:36:23 2014 +0100

    do not propose check bad blocks for btrfs (Manuel Hiebel, mga#10116)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=29d9934ca3d8493b249efc6b883590fdbc08408a
Comment 11 Manuel Hiebel 2014-01-13 12:26:55 CET
it doesn't looks to work but I don't understand why, as reiserfs or xfs does
Comment 12 Barry Jackson 2014-01-13 12:44:48 CET
(In reply to Manuel Hiebel from comment #11)
> it doesn't looks to work but I don't understand why, as reiserfs or xfs does

AFAIR I was not selecting to check bad blocks when I reported this bug originally.