Attachment 9558 Details for Bug 21433 – in my testing, it wasn't possible to actually change the directory on mga6

[patch] in my testing, it wasn't possible to actually change the directory on mga6

0002-use-the-right-signal.patch (text/plain), 1.01 KB, created by Thierry Vignaud on 2017-08-02 17:53:32 CEST

(hide)

Description:

Filename:

MIME Type:

Creator: Thierry Vignaud

Created: 2017-08-02 17:53:32 CEST

Size: 1.01 KB

patch

obsolete

>From 13f194e4121a5f1f3b60b4b7890fe7d80a6157ce Mon Sep 17 00:00:00 2001
>From: Thierry Vignaud <thierry.vignaud@gmail.com>
>Date: Wed, 2 Aug 2017 17:48:42 +0200
>Subject: [PATCH 2/3] use the right signal
>
>'current-folder-changed' no longer seems to work.
>Fix retrieving the filename with the new signal.
>---
> mgaapplet | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/mgaapplet b/mgaapplet
>index 8e667d3e..a0cd3968 100755
>--- a/mgaapplet
>+++ b/mgaapplet
>@@ -393,8 +393,8 @@ sub confirm_upgrade() {
>     my $browse;
>     $browse = gtksignal_connect(
>         Gtk3::FileChooserButton->new(N("Browse"), 'select-folder'),
>-        'current-folder-changed' => sub {
>-            $temp_dir = $_[0]->get_current_folder;
>+        'selection-changed' => sub {
>+            $temp_dir = $_[0]->get_filename;
>             my $ok = -d $temp_dir && ! -l $temp_dir && ((stat($temp_dir))[4] == 0);
>             $ok or ask_warn(N("Error"), N("You must choose a directory owned by the super administrator!"));
>         });
>-- 
>2.13.3
>

From 13f194e4121a5f1f3b60b4b7890fe7d80a6157ce Mon Sep 17 00:00:00 2001
From: Thierry Vignaud <thierry.vignaud@gmail.com>
Date: Wed, 2 Aug 2017 17:48:42 +0200
Subject: [PATCH 2/3] use the right signal

'current-folder-changed' no longer seems to work.
Fix retrieving the filename with the new signal.
---
 mgaapplet | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mgaapplet b/mgaapplet
index 8e667d3e..a0cd3968 100755
--- a/mgaapplet
+++ b/mgaapplet
@@ -393,8 +393,8 @@ sub confirm_upgrade() {
     my $browse;
     $browse = gtksignal_connect(
         Gtk3::FileChooserButton->new(N("Browse"), 'select-folder'),
-        'current-folder-changed' => sub {
-            $temp_dir = $_[0]->get_current_folder;
+        'selection-changed' => sub {
+            $temp_dir = $_[0]->get_filename;
             my $ok = -d $temp_dir && ! -l $temp_dir && ((stat($temp_dir))[4] == 0);
             $ok or ask_warn(N("Error"), N("You must choose a directory owned by the super administrator!"));
         });
-- 
2.13.3

Actions: View | Diff

Attachments on bug 21433: 9558 | 9559 | 9562