Mageia Bugzilla – Attachment 8777 Details for
Bug 19930
On Mga6 netinstall, progress bar is not available when installing packages, (at least since DrakX v17.64)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
New Account
|
Forgot Password
[patch]
revert forcing $progress_total & $ratio to be int64
0002-revert-forcing-progress_total-ratio-to-be-int64.patch (text/plain), 1.42 KB, created by
Thierry Vignaud
on 2016-12-14 16:43:28 CET
(
hide
)
Description:
revert forcing $progress_total & $ratio to be int64
Filename:
MIME Type:
Creator:
Thierry Vignaud
Created:
2016-12-14 16:43:28 CET
Size:
1.42 KB
patch
obsolete
>From aac4bd69cf4116f67177b5d800c1533783f789ef Mon Sep 17 00:00:00 2001 >From: Thierry Vignaud <thierry.vignaud@gmail.com> >Date: Wed, 14 Dec 2016 16:42:04 +0100 >Subject: [PATCH 2/2] revert forcing $progress_total & $ratio to be int64 > >--- > perl-install/install/steps_gtk.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/perl-install/install/steps_gtk.pm b/perl-install/install/steps_gtk.pm >index 9f62037..61f367f 100644 >--- a/perl-install/install/steps_gtk.pm >+++ b/perl-install/install/steps_gtk.pm >@@ -597,7 +597,7 @@ sub installPackages { > gtknew('Image', file_ref => \$advertising_image, show_ref => \$show_advertising), > ])); > >- my $progress_total = int64(0); >+ my $progress_total = 0; > $box->pack_end(gtkshow(gtknew('VBox', border_width => 7, spacing => 3, children_loose => [ > gtknew('ScrolledWindow', child => $pkg_log_widget, > hide_ref => \$show_advertising, height => 250, to_bottom => 1), >@@ -656,9 +656,9 @@ sub installPackages { > > my $dtime = time() - $o->{install_start_time}; > my $ratio = >- $total_size == 0 ? int64(0) : >+ $total_size == 0 ? 0 : > install::pkgs::size2time($current_total_size + $amount, $total_size) / install::pkgs::size2time($total_size, $total_size); >- $ratio >= 1 and $ratio = int64(1); >+ $ratio >= 1 and $ratio = 1; > my $total_time = $ratio ? $dtime / $ratio : time(); > > gtkval_modify(\$progress_total, $ratio); >-- >2.10.2 >
From aac4bd69cf4116f67177b5d800c1533783f789ef Mon Sep 17 00:00:00 2001 From: Thierry Vignaud <thierry.vignaud@gmail.com> Date: Wed, 14 Dec 2016 16:42:04 +0100 Subject: [PATCH 2/2] revert forcing $progress_total & $ratio to be int64 --- perl-install/install/steps_gtk.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/perl-install/install/steps_gtk.pm b/perl-install/install/steps_gtk.pm index 9f62037..61f367f 100644 --- a/perl-install/install/steps_gtk.pm +++ b/perl-install/install/steps_gtk.pm @@ -597,7 +597,7 @@ sub installPackages { gtknew('Image', file_ref => \$advertising_image, show_ref => \$show_advertising), ])); - my $progress_total = int64(0); + my $progress_total = 0; $box->pack_end(gtkshow(gtknew('VBox', border_width => 7, spacing => 3, children_loose => [ gtknew('ScrolledWindow', child => $pkg_log_widget, hide_ref => \$show_advertising, height => 250, to_bottom => 1), @@ -656,9 +656,9 @@ sub installPackages { my $dtime = time() - $o->{install_start_time}; my $ratio = - $total_size == 0 ? int64(0) : + $total_size == 0 ? 0 : install::pkgs::size2time($current_total_size + $amount, $total_size) / install::pkgs::size2time($total_size, $total_size); - $ratio >= 1 and $ratio = int64(1); + $ratio >= 1 and $ratio = 1; my $total_time = $ratio ? $dtime / $ratio : time(); gtkval_modify(\$progress_total, $ratio); -- 2.10.2
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 19930
:
8776
| 8777 |
8797