Attachment 8751 Details for Bug 19895 – make sure ratio is an int64 (mga#19895) as this is the variable that cause issues

[patch] make sure ratio is an int64 (mga#19895) as this is the variable that cause issues

0001-make-sure-ratio-is-an-int64-mga-19895.patch (text/plain), 1.03 KB, created by Thierry Vignaud on 2016-12-11 18:40:59 CET

(hide)

Description:

Filename:

MIME Type:

Creator: Thierry Vignaud

Created: 2016-12-11 18:40:59 CET

Size: 1.03 KB

patch

obsolete

>From ddb2cd3aabf56c03490a614e6b08f7245b3e08f4 Mon Sep 17 00:00:00 2001
>From: Thierry Vignaud <thierry.vignaud@gmail.com>
>Date: Sun, 11 Dec 2016 18:39:05 +0100
>Subject: [PATCH] make sure ratio is an int64 (mga#19895)
>
>as this is the variable that cause issues
>---
> perl-install/install/steps_gtk.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/perl-install/install/steps_gtk.pm b/perl-install/install/steps_gtk.pm
>index f3ae0a7..c065806 100644
>--- a/perl-install/install/steps_gtk.pm
>+++ b/perl-install/install/steps_gtk.pm
>@@ -655,9 +655,9 @@ sub installPackages {
> 
> 	    my $dtime = time() - $o->{install_start_time};
> 	    my $ratio = 
>-	      $total_size == 0 ? 0 :
>+	      $total_size == 0 ? int64(0) :
> 		install::pkgs::size2time($current_total_size + $amount, $total_size) / install::pkgs::size2time($total_size, $total_size);
>-	    $ratio >= 1 and $ratio = 1;
>+	    $ratio >= 1 and $ratio = int64(1);
> 	    my $total_time = $ratio ? $dtime / $ratio : time();
> 
> 	    gtkval_modify(\$progress_total, $ratio);
>-- 
>2.10.2
>

From ddb2cd3aabf56c03490a614e6b08f7245b3e08f4 Mon Sep 17 00:00:00 2001
From: Thierry Vignaud <thierry.vignaud@gmail.com>
Date: Sun, 11 Dec 2016 18:39:05 +0100
Subject: [PATCH] make sure ratio is an int64 (mga#19895)

as this is the variable that cause issues
---
 perl-install/install/steps_gtk.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/perl-install/install/steps_gtk.pm b/perl-install/install/steps_gtk.pm
index f3ae0a7..c065806 100644
--- a/perl-install/install/steps_gtk.pm
+++ b/perl-install/install/steps_gtk.pm
@@ -655,9 +655,9 @@ sub installPackages {
 
 	    my $dtime = time() - $o->{install_start_time};
 	    my $ratio = 
-	      $total_size == 0 ? 0 :
+	      $total_size == 0 ? int64(0) :
 		install::pkgs::size2time($current_total_size + $amount, $total_size) / install::pkgs::size2time($total_size, $total_size);
-	    $ratio >= 1 and $ratio = 1;
+	    $ratio >= 1 and $ratio = int64(1);
 	    my $total_time = $ratio ? $dtime / $ratio : time();
 
 	    gtkval_modify(\$progress_total, $ratio);
-- 
2.10.2

Actions: View | Diff

Attachments on bug 19895: 8727 | 8733 | 8748 | 8749 | 8750 | 8751