Mageia Bugzilla – Attachment 6521 Details for
Bug 15257
Live installer (not live mode) partitioner: Available disk space is not computed correctly (at least in small VM disks)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
New Account
|
Forgot Password
[patch]
better reporting of insufficient space (mga#15257)
0001-better-reporting-of-insufficient-space-mga-15257.patch (text/plain), 1.34 KB, created by
Thierry Vignaud
on 2015-05-12 10:33:41 CEST
(
hide
)
Description:
better reporting of insufficient space (mga#15257)
Filename:
MIME Type:
Creator:
Thierry Vignaud
Created:
2015-05-12 10:33:41 CEST
Size:
1.34 KB
patch
obsolete
>From 79fbb8a031ed8e3019f17fc128b75be5834faac9 Mon Sep 17 00:00:00 2001 >From: Thierry Vignaud <thierry.vignaud@gmail.com> >Date: Tue, 12 May 2015 04:31:12 -0400 >Subject: [PATCH] better reporting of insufficient space (mga#15257) > >When the live installer checks if there is sufficient space on the >chosen root partition it subtracts 10% (or 65MB) from the available >space to give some headroom. It's better to add the headroom to the >required space, as this gives a more accurate message when there is >insufficient space. >--- > draklive-install | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/draklive-install b/draklive-install >index e54245e..eacbc1d 100755 >--- a/draklive-install >+++ b/draklive-install >@@ -176,8 +176,9 @@ sub ask_partitions { > fs::any::check_hds_boot_and_root($all_hds, $fstab); > fs::partitioning::choose_partitions_to_format($in, $fstab); > >- my $total = get_total_size($in, $copy_source); >- my $available = fs::any::getAvailableSpace($fstab, 'skip_mounted'); >+ my $total = get_total_size($in, $copy_source) >+ my $available = fs::any::getAvailableSpace($fstab, 'skip_mounted', 1); >+ $total += fs::any::getNeededMinSpace($available); > die N("Not enough space available (%s available while %s are needed)", > formatXiB($available), formatXiB($total)) . "\n" > if $total > $available; >-- >2.3.2 >
From 79fbb8a031ed8e3019f17fc128b75be5834faac9 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud <thierry.vignaud@gmail.com> Date: Tue, 12 May 2015 04:31:12 -0400 Subject: [PATCH] better reporting of insufficient space (mga#15257) When the live installer checks if there is sufficient space on the chosen root partition it subtracts 10% (or 65MB) from the available space to give some headroom. It's better to add the headroom to the required space, as this gives a more accurate message when there is insufficient space. --- draklive-install | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/draklive-install b/draklive-install index e54245e..eacbc1d 100755 --- a/draklive-install +++ b/draklive-install @@ -176,8 +176,9 @@ sub ask_partitions { fs::any::check_hds_boot_and_root($all_hds, $fstab); fs::partitioning::choose_partitions_to_format($in, $fstab); - my $total = get_total_size($in, $copy_source); - my $available = fs::any::getAvailableSpace($fstab, 'skip_mounted'); + my $total = get_total_size($in, $copy_source) + my $available = fs::any::getAvailableSpace($fstab, 'skip_mounted', 1); + $total += fs::any::getNeededMinSpace($available); die N("Not enough space available (%s available while %s are needed)", formatXiB($available), formatXiB($total)) . "\n" if $total > $available; -- 2.3.2
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 15257
:
6245
|
6517
|
6518
|
6519
|
6520
| 6521