Attachment 6468 Details for Bug 14869 – File sections that have errors in the same functions

File sections that have errors in the same functions

file_14869.txt (text/plain), 1.29 KB, created by Mauricio Andrés Bustamante Viveros on 2015-05-07 17:28:12 CEST

(hide)

Description:

Filename:

MIME Type:

Creator: Mauricio Andrés Bustamante Viveros

Created: 2015-05-07 17:28:12 CEST

Size: 1.29 KB

patch

obsolete

>The section of the function that have the problem states: (from original file intel_display.c)
>
>4720 	/*
>         * Gen2 reports pipe underruns whenever all planes are disabled.
>         * So don't enable underrun reporting before at least some planes
>	 * are enabled.
>         * FIXME: Need to fix the logic to work when we turn off all planes
>	 * but leave the pipe running.
>         */
>	if (IS_GEN2(dev))
>4728            intel_set_cpu_fifo_underrun_reporting(dev, pipe, true);
>
>        drm_crtc_vblank_on(crtc);
>
>	/* Underruns don't raise interrupts, so check manually. */
>4733	i9xx_check_fifo_underruns(dev);
>
>BUT 
>
>4762 	/*
>	 * Gen2 reports pipe underruns whenever all planes are disabled.
>	 * So diasble underrun reporting before all the planes get disabled.
>	 * FIXME: Need to fix the logic to work when we turn off all planes
>	 * but leave the pipe running.
>	 */
>	if (IS_GEN2(dev))
>		intel_set_cpu_fifo_underrun_reporting(dev, pipe, false);
>
>	intel_crtc_disable_planes(crtc);
>
>	for_each_encoder_on_crtc(dev, crtc, encoder)
>4774		encoder->disable(encoder);
>4775
>
>
>This if (IS_GEN2(dev))
>4769		intel_set_cpu_fifo_underrun_reporting(dev, pipe, false); 
>have false in the boolean, but the 4728 line states true..... mod this 4728 line give as result no fifo underrun message....
>

The section of the function that have the problem states: (from original file intel_display.c)

4720 	/*
         * Gen2 reports pipe underruns whenever all planes are disabled.
         * So don't enable underrun reporting before at least some planes
	 * are enabled.
         * FIXME: Need to fix the logic to work when we turn off all planes
	 * but leave the pipe running.
         */
	if (IS_GEN2(dev))
4728            intel_set_cpu_fifo_underrun_reporting(dev, pipe, true);

        drm_crtc_vblank_on(crtc);

	/* Underruns don't raise interrupts, so check manually. */
4733	i9xx_check_fifo_underruns(dev);

BUT 

4762 	/*
	 * Gen2 reports pipe underruns whenever all planes are disabled.
	 * So diasble underrun reporting before all the planes get disabled.
	 * FIXME: Need to fix the logic to work when we turn off all planes
	 * but leave the pipe running.
	 */
	if (IS_GEN2(dev))
		intel_set_cpu_fifo_underrun_reporting(dev, pipe, false);

	intel_crtc_disable_planes(crtc);

	for_each_encoder_on_crtc(dev, crtc, encoder)
4774		encoder->disable(encoder);
4775


This if (IS_GEN2(dev))
4769		intel_set_cpu_fifo_underrun_reporting(dev, pipe, false); 
have false in the boolean, but the 4728 line states true..... mod this 4728 line give as result no fifo underrun message....

Actions: View

Attachments on bug 14869: 5750 | 5760 | 5793 | 6297 | 6468