Attachment 6250 Details for Bug 15664 – try harder to erase disk with RAID/LVM

[patch] try harder to erase disk with RAID/LVM

15664.diff (text/plain), 1.10 KB, created by Thierry Vignaud on 2015-04-13 00:20:38 CEST

(hide)

Description:

Filename:

MIME Type:

Creator: Thierry Vignaud

Created: 2015-04-13 00:20:38 CEST

Size: 1.10 KB

patch

obsolete

>try harder to erase disk with RAID/LVM
>
>still fails with "Remove the logical volumes first" because RemoveFromLVM()
>calls lvm::vg_destroy() w/o removing the LVs first
>
>If one manually run lvremove, one can go on.
>
>
>Likewise for RAIDs, it fails to remove partitions belonging to RAID (busty) despite raid::removeDisk() having called mdadm --stop
>
>Running mdadm --zero-superblock on each member is needed...
>
>diff -up ./fs/partitioning_wizard.pm.tv2 ./fs/partitioning_wizard.pm
>--- ./fs/partitioning_wizard.pm.tv2	2015-04-12 23:27:40.950344633 +0200
>+++ ./fs/partitioning_wizard.pm	2015-04-12 23:27:26.248345315 +0200
>@@ -250,7 +250,7 @@ filesystem checks will be run on your ne
> 		$in->ask_okcancel_({ messages => N("ALL existing partitions and their data will be lost on drive %s", partition_table::description($hd)),
> 				    title => N("Partitioning"),
> 				    interactive_help_id => 'takeOverHdConfirm' }) or return;
>-		fsedit::partition_table_clear_and_initialize($all_hds->{lvms}, $hd, $in);
>+		diskdrake::interactive::Clear_all($in, $hd, $all_hds);
> 		fsedit::auto_allocate($all_hds, $partitions);
> 		1;
> 	    } ];

try harder to erase disk with RAID/LVM

still fails with "Remove the logical volumes first" because RemoveFromLVM()
calls lvm::vg_destroy() w/o removing the LVs first

If one manually run lvremove, one can go on.


Likewise for RAIDs, it fails to remove partitions belonging to RAID (busty) despite raid::removeDisk() having called mdadm --stop

Running mdadm --zero-superblock on each member is needed...

diff -up ./fs/partitioning_wizard.pm.tv2 ./fs/partitioning_wizard.pm
--- ./fs/partitioning_wizard.pm.tv2	2015-04-12 23:27:40.950344633 +0200
+++ ./fs/partitioning_wizard.pm	2015-04-12 23:27:26.248345315 +0200
@@ -250,7 +250,7 @@ filesystem checks will be run on your ne
 		$in->ask_okcancel_({ messages => N("ALL existing partitions and their data will be lost on drive %s", partition_table::description($hd)),
 				    title => N("Partitioning"),
 				    interactive_help_id => 'takeOverHdConfirm' }) or return;
-		fsedit::partition_table_clear_and_initialize($all_hds->{lvms}, $hd, $in);
+		diskdrake::interactive::Clear_all($in, $hd, $all_hds);
 		fsedit::auto_allocate($all_hds, $partitions);
 		1;
 	    } ];

Actions: View | Diff

Attachments on bug 15664: 6250