Attachment 11581 Details for Bug 26368 – Untest patch to add a link to the source repo.

[patch] Untest patch to add a link to the source repo.

0001-add-a-link-to-the-source-untested.patch (text/plain), 1.12 KB, created by Shlomi Fish on 2020-04-10 19:44:40 CEST

(hide)

Description:

Filename:

MIME Type:

Creator: Shlomi Fish

Created: 2020-04-10 19:44:40 CEST

Size: 1.12 KB

patch

obsolete

>From 1c7baa5073cf2c2f322285f5e0cb36c092c56ab9 Mon Sep 17 00:00:00 2001
>From: Shlomi Fish <shlomif@shlomifish.org>
>Date: Fri, 10 Apr 2020 20:42:01 +0300
>Subject: [PATCH] add a link to the source (untested).
>
>See https://bugs.mageia.org/show_bug.cgi?id=26368 :
>
>=======
>
>https://check.mageia.org/ should contain a link to the source code that
>is used to generate it . Currently, it is not clear and it is the
>"unwritten knowledge in the ether" antipattern.
>
>====
>---
> lib/Youri/Check/Output/File/Format/HTML.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/lib/Youri/Check/Output/File/Format/HTML.pm b/lib/Youri/Check/Output/File/Format/HTML.pm
>index c498bbd..492fd45 100644
>--- a/lib/Youri/Check/Output/File/Format/HTML.pm
>+++ b/lib/Youri/Check/Output/File/Format/HTML.pm
>@@ -195,6 +195,9 @@ sub _get_html_page {
>         { class => 'footer' },
>         "Page generated $time"
>     );
>+    $content .= <<"EOF";
>+<footer><p>This page was generated by <a href="https://gitweb.mageia.org/software/build-system/mga-youri-core/">mga-youri-core</a>.</p></footer>
>+EOF
>     $content .= $self->{_cgi}->end_html();
> 
>     return \$content;
>-- 
>2.26.0
>

From 1c7baa5073cf2c2f322285f5e0cb36c092c56ab9 Mon Sep 17 00:00:00 2001
From: Shlomi Fish <shlomif@shlomifish.org>
Date: Fri, 10 Apr 2020 20:42:01 +0300
Subject: [PATCH] add a link to the source (untested).

See https://bugs.mageia.org/show_bug.cgi?id=26368 :

=======

https://check.mageia.org/ should contain a link to the source code that
is used to generate it . Currently, it is not clear and it is the
"unwritten knowledge in the ether" antipattern.

====
---
 lib/Youri/Check/Output/File/Format/HTML.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/Youri/Check/Output/File/Format/HTML.pm b/lib/Youri/Check/Output/File/Format/HTML.pm
index c498bbd..492fd45 100644
--- a/lib/Youri/Check/Output/File/Format/HTML.pm
+++ b/lib/Youri/Check/Output/File/Format/HTML.pm
@@ -195,6 +195,9 @@ sub _get_html_page {
         { class => 'footer' },
         "Page generated $time"
     );
+    $content .= <<"EOF";
+<footer><p>This page was generated by <a href="https://gitweb.mageia.org/software/build-system/mga-youri-core/">mga-youri-core</a>.</p></footer>
+EOF
     $content .= $self->{_cgi}->end_html();

     return \$content;
-- 
2.26.0

Actions: View | Diff

Attachments on bug 26368: 11581