Attachment 10797 Details for Bug 23904 – Proposed fix

Proposed fix

0001-installer-fix-screen-layout-when-the-framebuffer-is-.patch (text/plain), 1.84 KB, created by Martin Whitaker on 2019-02-26 22:49:28 CET

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Whitaker

Created: 2019-02-26 22:49:28 CET

Size: 1.84 KB

patch

obsolete

>From d839b037a2eb14d82604dad4069c95c504c90234 Mon Sep 17 00:00:00 2001
>From: Martin Whitaker <mageia@martin-whitaker.me.uk>
>Date: Tue, 26 Feb 2019 21:26:02 +0000
>Subject: [PATCH] installer: fix screen layout when the framebuffer is >
> 1024x768 (mga#23904)
>
>On some hardware, the framebuffer remains at native panel resolution,
>regardless of the vga= setting on the boot command line, but we only
>support fixed size layouts of 1024x768 or 800x600. To improve the
>appearance:
>
>  - centre the main window
>  - limit the "real_window" size to prevent subsidiary windows expanding
>    outside the main window
>
>diff --git a/perl-install/install/NEWS b/perl-install/install/NEWS
>index b84e356d6..e3ce43ec6 100644
>--- a/perl-install/install/NEWS
>+++ b/perl-install/install/NEWS
>@@ -1,3 +1,5 @@
>+- fix screen layout when the framebuffer is > 1024x768 (mga#23904)
>+
> Version 18.10 - 3 Feb 2019
> 
> - skip setupSCSI step when run with --local_install (mga#24278)
>diff --git a/perl-install/install/gtk.pm b/perl-install/install/gtk.pm
>index 37b31c109..094f3617e 100644
>--- a/perl-install/install/gtk.pm
>+++ b/perl-install/install/gtk.pm
>@@ -163,7 +163,8 @@ sub create_steps_window {
>                    ],
>              )
>     );
>-        
>+
>+    $root_window->set_position(GTK_WIN_POS_CENTER_ALWAYS);
>     $root_window->show_all;
> }
> 
>@@ -221,8 +222,8 @@ sub init_sizes {
>     $::stepswidth = $::rootwidth <= 640 ? 0 : 196;
>     ($o->{windowwidth}, $o->{windowheight}) = ($::rootwidth - $::stepswidth, $::rootheight);
>     # Adapt the window size to available screen width and height.
>-    $::real_windowwidth = $::rootwidth > 800 ? $::rootwidth - 224 : 576;
>-    $::real_windowheight = $::rootheight > 600 ? $::rootheight - 135 : 465;
>+    $::real_windowwidth = $::rootwidth > 800 ? 800 : 576;
>+    $::real_windowheight = $::rootheight > 600 ? 633 : 465;
> }
> 
> sub handle_unsafe_mouse {
>-- 
>2.13.7
>

From d839b037a2eb14d82604dad4069c95c504c90234 Mon Sep 17 00:00:00 2001
From: Martin Whitaker <mageia@martin-whitaker.me.uk>
Date: Tue, 26 Feb 2019 21:26:02 +0000
Subject: [PATCH] installer: fix screen layout when the framebuffer is >
 1024x768 (mga#23904)

On some hardware, the framebuffer remains at native panel resolution,
regardless of the vga= setting on the boot command line, but we only
support fixed size layouts of 1024x768 or 800x600. To improve the
appearance:

  - centre the main window
  - limit the "real_window" size to prevent subsidiary windows expanding
    outside the main window

diff --git a/perl-install/install/NEWS b/perl-install/install/NEWS
index b84e356d6..e3ce43ec6 100644
--- a/perl-install/install/NEWS
+++ b/perl-install/install/NEWS
@@ -1,3 +1,5 @@
+- fix screen layout when the framebuffer is > 1024x768 (mga#23904)
+
 Version 18.10 - 3 Feb 2019
 
 - skip setupSCSI step when run with --local_install (mga#24278)
diff --git a/perl-install/install/gtk.pm b/perl-install/install/gtk.pm
index 37b31c109..094f3617e 100644
--- a/perl-install/install/gtk.pm
+++ b/perl-install/install/gtk.pm
@@ -163,7 +163,8 @@ sub create_steps_window {
                    ],
              )
     );
-        
+
+    $root_window->set_position(GTK_WIN_POS_CENTER_ALWAYS);
     $root_window->show_all;
 }
 
@@ -221,8 +222,8 @@ sub init_sizes {
     $::stepswidth = $::rootwidth <= 640 ? 0 : 196;
     ($o->{windowwidth}, $o->{windowheight}) = ($::rootwidth - $::stepswidth, $::rootheight);
     # Adapt the window size to available screen width and height.
-    $::real_windowwidth = $::rootwidth > 800 ? $::rootwidth - 224 : 576;
-    $::real_windowheight = $::rootheight > 600 ? $::rootheight - 135 : 465;
+    $::real_windowwidth = $::rootwidth > 800 ? 800 : 576;
+    $::real_windowheight = $::rootheight > 600 ? 633 : 465;
 }
 
 sub handle_unsafe_mouse {
-- 
2.13.7

Actions: View

Attachments on bug 23904: 10506 | 10797